Skip to content

Returns the shader name you're aiming at.#224

Open
lumayaa wants to merge 3 commits intotaysta:masterfrom
lumayaa:master
Open

Returns the shader name you're aiming at.#224
lumayaa wants to merge 3 commits intotaysta:masterfrom
lumayaa:master

Conversation

@lumayaa
Copy link
Copy Markdown

@lumayaa lumayaa commented Apr 19, 2025

No description provided.

Copy link
Copy Markdown
Owner

@taysta taysta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for your pull request, this is a cool feature. I am curious why it sends the shader as a chat message rather than a client-side console print. The rest looks good.

if (tr.fraction < 1.0f && tw.leadside)
{
CCMShader *shader = &cmg.shaders[tw.leadside->shaderNum];
CL_AddReliableCommand(va("say ^2[ShaderTrace]^7: ^6%s", shader->shader), qfalse);
Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a reason why this is sending the server a chat message instead of a console print?

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Others might be interested in it, I don't mind if u change it.

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd much prefer it to be a console output, there could be scenarios where the user doesn't want to announce their shadertrace.

@taysta
Copy link
Copy Markdown
Owner

taysta commented Apr 21, 2025

Just tested it, it seems to work some times but is very inconsistent. Probably needs to filter out caulk too as that is the response most of the time currently.

@lumayaa
Copy link
Copy Markdown
Author

lumayaa commented Apr 21, 2025

Just tested it, it seems to work some times but is very inconsistent. Probably needs to filter out caulk too as that is the response most of the time currently.

Mhm, it works on the world but it doesnt like entities at the moment. Could be expanded in the future

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants