some improvements #16
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…enizerBase::next_pos()
so some unnecessary checks are removed
|
LGTM — 88bd078 took a 2 min parsing operation down to 10 seconds in one test. But RIP tburry/pquery :) |
|
Note there is some inconsistency between tabs and spaces within the source code, there is already inconsistency between files, but one line in the PR adds spaces into a file that has tabs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The most important commit 88bd078 give the parser a big performance boost.
I've tested this with PHP 7.1.12 on some html files (size ~5kb), the parsing time decreases from ~4 seconds to under 0.1 seconds.