Skip to content
This repository was archived by the owner on Jun 24, 2024. It is now read-only.

Specify resolving sources#32

Open
jridgewell wants to merge 2 commits intotc39:mainfrom
jridgewell:spec-resolve
Open

Specify resolving sources#32
jridgewell wants to merge 2 commits intotc39:mainfrom
jridgewell:spec-resolve

Conversation

@jridgewell
Copy link
Member

@jridgewell jridgewell commented Mar 5, 2024

I had a bug in my source URL resolution where I resolved sourceMappingUrl and sourceRoot, then used that result to resolve source. The under-specified behavior is that sourceRoot is prepended (treating it as a directory) to source, then resolved using sourceMappingUrl as the base.

Implementations:

Open questions:

@hybrist
Copy link
Collaborator

hybrist commented May 4, 2024

Should this PR be ported to https://github.com/tc39/source-map instead, now that the spec has moved?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants