Fix format query to preserve identifier case#833
Open
r-cha wants to merge 1 commit intotconbeer:mainfrom
Open
Conversation
- Changed sqlfmt Mode to use 'clickhouse' dialect instead of default 'polyglot' - ClickHouse dialect preserves case of table names, column names, and other identifiers - SQL keywords are still formatted to lowercase as expected - Added test to verify identifier case preservation - Fixes issue where Format Query (F4) would break case-sensitive queries Fixes tconbeer#813 Co-authored-by: Amp <amp@ampcode.com> Amp-Thread-ID: https://ampcode.com/threads/T-446eb4fc-ccaf-462a-9848-155ee06dd5f4
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes #817 where the Format Query function was converting all identifiers (table names, column names, etc.) to lowercase, potentially breaking queries that rely on case-sensitive identifiers.
Problem
Previously, when using Format Query:
SELECT FirstName FROM UserTablewould becomeselect firstname from usertableSolution
Changed the sqlfmt Mode configuration to use the 'clickhouse' dialect instead of the default 'polyglot' dialect. The ClickHouse dialect preserves case of user-defined identifiers (table names, column names, function names) but is otherwise identical to the previous behavior.