Open
Conversation
Contributor
shivamgangwani
commented
Jul 4, 2022
shivamgangwani
commented
- Move API from flask development server to gunicorn (Adjust number of workers as per cores in the docker-compose file)
- Move UI from React development server to a build (optimized for performance)
- UI was making two calls to /getDerivedData whenever assembly box was checked. I think this is because assembliesChecked is already a part of the state and then we were calling fetchTableData separately as well - have tried to fix this
- Another minor bug fix for API (API call was being made when no assemblies were selected) - added check in BrowseData.js to prevent this
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.