Feats: Handling missing data and fixing numCandidatesMap issue#91
Open
kkkarnav wants to merge 17 commits intoADR_chartsfrom
Open
Feats: Handling missing data and fixing numCandidatesMap issue#91kkkarnav wants to merge 17 commits intoADR_chartsfrom
kkkarnav wants to merge 17 commits intoADR_chartsfrom
Conversation
The class methods getColorForContinuous GetColorForNormalizedMap and GetColorForChangeMap had three if-statements each to return the data-unavailable colour. Replaced all nine if-statements with one class method, isDataUnavailable()
Fixes issue where the legend and map colors were not the same for NumCandidatesMap maps Adds refactor isDataUnavailable to all maps
Feats: Handling missing data and fixing numCandidatesMap issue
fix: isdataunavailable diff and datafilteroptions check
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds error handling for missing data so that the app gracefully moves to a missing data screen without crashing
Refactors getColor methods and fixes the issue where constituency maps had discrepancies between map colors and legend colors