Merged
Conversation
test-level1.mojo
Outdated
| var d2 = generate_random_scalar[dtype](1, 10000) | ||
| var x1 = generate_random_scalar[dtype](-10000, 10000) | ||
| var y1 = generate_random_scalar[dtype](-10000, 10000) | ||
| var param = SIMD[dtype, 5]() |
Collaborator
There was a problem hiding this comment.
We're passing a pointer to a SIMD type of width 5 here, and then in the kernel we're accessing param[0] which is of type SIMD[dtype, 5]. So when overwriting param[0] in the kernel we're actually setting all 5 values at once.
This should probably just be a list of DType that gets passed in directly
src/level1/rotmg.mojo
Outdated
| d2: UnsafePointer[Scalar[dtype], MutAnyOrigin], | ||
| x1: UnsafePointer[Scalar[dtype], MutAnyOrigin], | ||
| y1: UnsafePointer[Scalar[dtype], MutAnyOrigin], | ||
| param: UnsafePointer[SIMD[dtype, 5], MutAnyOrigin] |
Collaborator
There was a problem hiding this comment.
param should be UnsafePointer[Scalar[dtype], MutAnyOrigin]
jacksonmowry
requested changes
Feb 25, 2026
Collaborator
|
WestonJB
force-pushed
the
jweston/rotmg
branch
2 times, most recently
from
1f22b0d to
f519184
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tests do not work. Assignment to param inside blas_rotmg is not working. Closes #22.