[New Command] Effective Hamiltonian #131
Draft
ejmeitz wants to merge 8 commits intotdep-developers:mainfrom
Draft
[New Command] Effective Hamiltonian #131ejmeitz wants to merge 8 commits intotdep-developers:mainfrom
ejmeitz wants to merge 8 commits intotdep-developers:mainfrom
Conversation
5d95810 to
682fdd9
Compare
Conflicts: src/anharmonic_free_energy/main.f90
Contributor
Author
|
Ok the harmonic average works now. This is useful for estimating the cumulants from sTDEP. |
Contributor
|
Any progress on the TODO list? should this be moved out of WIP? Please merge latest trunk and Alois or I can review the code |
Contributor
Author
|
I am not sure how to sanity check the polar contribution. Things like I'm not using this code anymore as I re-implemented everything in Julia, but happy to get this merged as I think its still useful. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This command calculates the effective Hamiltonian given trajectory data or optionally can generate configurations a la
canonical_configurationsto get a "harmonic average". Beyond calculating the energy, this will be useful to checking the convergence of U0 as well as other cumulants that could be used byanharmonic_free_energy. I also need this to check the accuracy of theanharmonic_free_energycommand and figured I'd make it a command since there was an open issue (#93).So far I have checked this against the existing energy calculator inside of
extract_forceconstantsand I get an exact math. There is still some work to ensure things are correct however. The bulk of the changes are done though and would be happy to get any revisions.TODO
Edit: Pls ignore the git history I made some mistakes :)