Conversation
Contributor
Author
|
Small note: I had to comment a call to an interface which had no implementation (in |
Contributor
|
Trying out now. Real time comments below:
|
Contributor
Author
|
List of improvements:
And for the documentation, I will improve it in another iteration. |
mjv500
approved these changes
Sep 2, 2025
Contributor
mjv500
left a comment
There was a problem hiding this comment.
Looks correct and functional now. Might add examples for other machines, MPI checks and other stuff. I don't know Meson enough to confirm these other options are present/easy/possible
Contributor
|
The compile and test phase on GitHub times out after 20 min. @MaxMignolet you can increase the timeout duration by hand in .github/workflows/ci_simple_compilation_and_test.yml |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR contains a new build system based on Meson. It improves the detection of libraries which (almost) fully automated . It also supports incremental compilation. I tested it on an intel mac, Ubuntu 22, and MareNostrum 5 with minimal issues. Feedback and testing on a wider range of machines/installations would be welcome.
Installation instruction have been added to
INSTALL.md.