Merged
Conversation
Test Results491 tests 491 ✅ 6s ⏱️ Results for commit 6f1b4cb. ♻️ This comment has been updated with latest results. |
MennaSrour
requested review from
Abdulrahman-Ragab-01,
AhmadKharfan,
Ahmed7osny1,
diyar214,
fatmahgazy,
marwanqashwa and
mosayed01
mosayed01
reviewed
May 15, 2025
mosayed01
reviewed
May 15, 2025
mosayed01
approved these changes
May 15, 2025
mosayed01
left a comment
mosayed01
left a comment
There was a problem hiding this comment.
just rename the module name @MennaSrour
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
-use singleOf instead of single in usecaseModule , uiModule and dataModule
-group exceptions and make them use base classes
-add repoModule