Adding metadata to form and elements for dynamic attributes.#90
Open
pat wants to merge 2 commits intoteam-formalist:masterfrom
Open
Adding metadata to form and elements for dynamic attributes.#90pat wants to merge 2 commits intoteam-formalist:masterfrom
pat wants to merge 2 commits intoteam-formalist:masterfrom
Conversation
This implementation is technically extremely simple - the meta hash isn’t considered to match the nested structure of elements/fields (unlike errors and inputs), hence there’s no digging through its structure as part of the rendering process. It’s combined with the ability to pass procs through as attribute values, and when rendering they get invoked with a single argument - the meta hash. And arguably there’s nothing stopping meta from being something other than a hash too. Entirely up to the consumer.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This addresses #89 in what feels to be a simple manner (and I'm very open to changing approaches). The meta object here is presumed to be a hash, but isn’t considered to match the nested structure of elements/fields (unlike errors and inputs), hence there’s no digging through its structure as part of the rendering process.
It’s combined with the ability to pass procs through as attribute values, and when rendering they get invoked with a single argument - the meta object. And arguably there’s nothing stopping meta from being something other than a hash too. Entirely up to the consumer.
(I realise 829ae93 is included here, because that's the branch we're working with, but it's completely unrelated to the focus of the PR.)