Dev - Request changes to the graphics/color.hpp and cpp files #20
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tual version is held in the cmake file)
i hope it still works on windows
thanks tuxcap!
idk how to really explain it
… you can actually use it... :| )
i think
This reverts commit 0edc279.
send help
…ITester, moved some functions around
todo: remove sdl_renderer or make them interchangable
This reverts commit fec73bc.
Change the order of RGBA components in RGBA struct and updated method name to reflect the correct formats.
Change these functions so this way RGBA is correctly defined, instead of using BGRA, and use ToBGRA method instead to correctly convert between (1) color format. Change ToInt to ensure proper clarification for the RGBA class.
Added YUV struct for color representation and updated Color class methods to include YUV conversion.
Added YUV conversion method and updated ToRGBAInt method name. Improved some comments for clarity.
Caused too much of a headache and too many errors
So this way crap can build correctly.
Updated RGBA struct to the standard ARGB format and modified related functions.
and use it throughout most of the functions for consistency with modern pixel/HTML standards.
Removed ToRGBA function to simplify color format handling.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.