This repository was archived by the owner on Jan 28, 2021. It is now read-only.
Open
Conversation
- upgrading solidity to 0.5.0
'call after transfer'
enjeyw
commented
Jan 22, 2020
|
|
||
| function transfer(address _to, uint256 _value) public returns (bool) { | ||
| require(superTransfer(_to, _value)); | ||
| callAfterTransfer(msg.sender, _to, _value); |
Contributor
Author
There was a problem hiding this comment.
removing callAfterTransfer to keep standard ERC20 behaviour
enjeyw
commented
Jan 22, 2020
| import "./interfaces/ERC677.sol"; | ||
|
|
||
| contract ERC677Token is ERC677, DetailedERC20, StandardToken { | ||
| contract ERC677Token is ERC20, ERC20Detailed, ERC677 { |
Contributor
Author
There was a problem hiding this comment.
New openzeppelin library changes a few contract names
enjeyw
commented
Jan 22, 2020
| emit WrapSwap(originalToken, wrappedToken, msg.sender); | ||
| emit WrapSwap(address(originalToken), address(wrappedToken), msg.sender); | ||
|
|
||
| return true; |
Contributor
Author
There was a problem hiding this comment.
retaining boolean returns to keep consistency with openzepplin library's implementation of erc20
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.