Adding a option to make your own close button styling#20
Open
tommachorek wants to merge 1 commit intoteamtv:mainfrom
Open
Adding a option to make your own close button styling#20tommachorek wants to merge 1 commit intoteamtv:mainfrom
tommachorek wants to merge 1 commit intoteamtv:mainfrom
Conversation
Added the feature for the option to implement your own close button with styling, changed up README.md and simple example to reflect it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added the feature for the option to implement your own close button with styling, changed up README.md and simple example to reflect it.
I've ran into a issue where I would like the button to look somehow different and that was not possible (as far as I could see) without another layer of hackish JS/CSS injections based on the class name hence this PR.
Can lead potentially to softlocks as when the option for lack of the close button is present it could result in inclosable modal.