Updating for Velocity 3.0.0 #183
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Changed imports to adventure - Changed TextComponent.of to Component.text - Changed TextColor to NamedTextColor
- Changed imports to adventure - Changed previous TextComponent.of to Component.text - Changed TextColor to NamedTextColor
- Changed imports to adventure - Changed previous TextComponent.of to Component.text - Changed TextColor to NamedTextColor
- Changed imports to adventure - Changed previous TextComponent.of to Component.text - Changed TextColor to NamedTextColor
- Changed imports to adventure - Changed previous TextComponent.of to Component.text - Changed TextColor to NamedTextColor
- Changed imports to adventure - Changed previous TextComponent.of to Component.text - Changed TextColor to NamedTextColor
- Changed imports to adventure - Changed previous TextComponent.of to Component.text - Changed TextColor to NamedTextColor
Added additional variables to work around old code
Author
|
Noticed that the BuycraftCommand file also needed a change from Command to SimpleCommand, along with a change to the passed values in the execute function so that it worked with the API. To work with the old code, two variables are also created to fill in what it used to use. See commits 3d2485c and 80e2a09 for that. |
|
Whoops I should have looked. This already exists, closing #188 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Good morning! I've been working on minor fixes for the Velocity portion of Buycraft. I've tested these changes locally by self-building, to which worked as expected. At this time, the current version of Buycraft for Velocity is non-functional under Velocity 3.0.0 conditions, these changes should solve this.
The main changes are as follows
Many thanks :)