Dependency Updates and more #112
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bumps [sidekiq](https://github.com/sidekiq/sidekiq) from 4.1.4 to 6.5.10. - [Changelog](https://github.com/sidekiq/sidekiq/blob/main/Changes.md) - [Commits](sidekiq/sidekiq@v4.1.4...v6.5.10) --- updated-dependencies: - dependency-name: sidekiq dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com>
tech-conferences#100 Move URL helper logic from app/lib to lib directory and simplify implementation Update Rails version to 7.1.3 and related gem dependencies Fix topic model to return nil in else case and add related topics in conference model
|
This PR originated from investigating compatibility issues after a dependency update (#100), which led to discovering and fixing several URL-related issues throughout the codebase. Please let me know what you guys think |
nimzco
reviewed
Jul 16, 2025
nimzco
reviewed
Jul 16, 2025
| related_topics = topics.map { |topic| Topic.related_topic(topic) }.compact.uniq | ||
| related_topics.each do |related_topic| | ||
| self.topics << related_topic unless self.topics.include?(related_topic) | ||
| end |
There was a problem hiding this comment.
Is this a bug you've noticed somewhere? Why this refactor?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes several updates to dependencies, helper methods, and model logic, as well as some cleanup and refactoring. The most significant changes involve updating gem dependencies, refactoring the
URLHelpermodule, and improving theConferencemodel's URL handling. Below are the key changes grouped by theme:Dependency Updates:
loofahgem from~> 2.3.1to~> 2.21,railsfrom~> 6.1.7.8to~> 7.1.3,sidekiqfrom~> 4.1.3to~> 6.5.10, andmochafrom1.7.0to~> 2.0in theGemfile. These updates bring in newer versions of the libraries, ensuring compatibility and security. [1] [2]Helper Refactoring:
URLHelperto a newmoduleinapp/helpers/url_helper.rbwith a simplifiedfix_urlmethod. Removed the oldURLHelperclass fromapp/lib/url_helper.rband added a new implementation inlib/url_helper.rbfor broader usage. [1] [2] [3]Model Enhancements:
Conferencemodel to use the newURLHelper.fix_urlmethod for normalizing URLs (url,cfpUrl,cocUrl) and moved thefix_urlmethod to abefore_validationcallback for better lifecycle management. Removed the oldfix_urlmethod implementation. [1] [2] [3]Logic Improvements:
add_related_topicin theConferencemodel to ensure no duplicate topics are added when computing related topics.Cleanup:
elsebranch in theTopicmodel'srelated_topicmethod, ensuring proper handling of unmatched cases.config.load_defaultsinconfig/application.rbfrom version5.1to5.2to align with the Rails upgrade.