fix: create engine/package.json before npm install to prevent global install#5
Open
Belkouche wants to merge 1 commit intotechjarves:mainfrom
Open
fix: create engine/package.json before npm install to prevent global install#5Belkouche wants to merge 1 commit intotechjarves:mainfrom
Belkouche wants to merge 1 commit intotechjarves:mainfrom
Conversation
…install Without a package.json in engine/, npm install falls back to a global install inside the portable Node prefix instead of creating a local node_modules/. This causes OC_BIN to never be found, falling through to `npx openclaude` which resolves a wrong package and errors with "could not determine executable to run". Fixes techjarves#4
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
package.jsoninengine/,npm installfalls back to a global install inside the portable Node prefix instead of creating a localnode_modules/OC_BINto never be found, falling through tonpx openclaudewhich resolves a wrong package (openclaude@0.0.1) with nobinfieldpackage.jsonintoengine/before runningnpm installFixes #4
Test plan
engine/node_modules/andengine/package.jsonto simulate a fresh clone./start.shand verify the engine installs intoengine/node_modules/(not globally)engine/node_modules/@gitlawb/openclaude/bin/openclaudeexists after install