-
Notifications
You must be signed in to change notification settings - Fork 11
docker-compose.yml #76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
@Lajithaalagarbabu is attempting to deploy a commit to the Techulus Team on Vercel. A member of the Team first needs to authorize it. |
WalkthroughA new Docker Compose configuration file is added for the Changes
Estimated code review effort1 (~2 minutes) Poem
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (5)
apps/page/docker-compose.yml (5)
1-1
: Prefer Compose spec3.9
(or omit version) for modern feature-set
Compose v3 without a minor version is from 2016 and lacks newer fields (e.g.,profiles
,deploy
). Unless you are targeting a legacy Docker Engine, bump to3.9
or drop the version key entirely (Compose v2 CLI treats this as latest).
4-5
: Pin the Node image to an exact patch version
node:18-alpine
is a moving tag; tomorrow’s build may silently pull a different revision and break reproducibility. Pick an explicit patch (node:18.20.2-alpine
) or use a locally built image viabuild:
.
6-7
: Mounting the whole project overwrites the container’snode_modules
Because/app
is bind-mounted, any dependencies installed during image build are lost andnpm install
must re-run on every container start, which is slow. Typical dev pattern:volumes: - .:/app - /app/node_modules # anonymous volume shields installed depsor switch to
npm ci
insidecommand:
for deterministic, faster installs.
8-8
: Replacenpm install && npm run dev
withnpm ci
for deterministic installs
npm install
may mutatepackage-lock.json
;npm ci
is faster and guarantees exact lockfile versions.- command: sh -c "npm install && npm run dev" + command: sh -c "npm ci && npm run dev"
9-10
: Expose host port via env to avoid clashes
Hard-coding3000:3000
collides if multiple apps bind to 3000 locally. Consider:ports: - "${HOST_PORT-3000}:3000"and add
HOST_PORT
to.env.example
.
Summary by CodeRabbit