Skip to content

test coverage improved #86

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dewaleolaoye wants to merge 10 commits into
base: develop
Choose a base branch
from
+490 −324
Open

test coverage improved #86

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
adf239c
test coverage improved
dewaleolaoye Oct 10, 2020
585682c
more test
dewaleolaoye Oct 13, 2020
83d53b8
log travis error
dewaleolaoye Oct 14, 2020
1bf1b61
this should fix it
dewaleolaoye Oct 14, 2020
7f2a3cf
increase script time
dewaleolaoye Oct 14, 2020
825b3bf
async and await test
dewaleolaoye Oct 14, 2020
e60187a
test
dewaleolaoye Oct 14, 2020
adafc30
remove timeout
dewaleolaoye Oct 14, 2020
286f49e
Modifies test coverage
misanj Oct 17, 2020
84fb491
Add more describe blocks
misanj Oct 19, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
111 changes: 111 additions & 0 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 3 additions & 0 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,6 +55,7 @@
"dotenv": "^7.0.0",
"errorhandler": "^1.5.1",
"express": "^4.17.1",
"faker": "5.1.0",
"jsonwebtoken": "^8.5.1",
"mocha": "^8.1.1",
"moment": "^2.27.0",
Expand All @@ -63,6 +64,8 @@
"pg": "^7.18.2",
"pg-hstore": "^2.3.3",
"sequelize": "^5.22.3",
"sinon": "9.2.0",
"sinon-chai": "3.5.0",
"swagger-jsdoc": "^4.0.0",
"swagger-ui-express": "^4.1.4"
},
Expand Down
10 changes: 5 additions & 5 deletions src/services/userServices.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import { User } from "../models";
import { User } from '../models';

/**
* User service Class
Expand Down Expand Up @@ -39,7 +39,7 @@ export default class UserServices {
const userDetails = await User.update(
{ [name]: value },
{ where: { id } },
{ returning: true }
{ returning: true },
);
return userDetails;
}
Expand Down Expand Up @@ -74,7 +74,7 @@ export default class UserServices {
Address,
gender,
phoneNumber,
memberType
memberType,
} = attribute;
const userDetails = await User.update(
{
Expand All @@ -85,9 +85,9 @@ export default class UserServices {
gender,
Address,
phoneNumber,
memberType
memberType,
},
{ where: { email }, returning: true, plain: true }
{ where: { email }, returning: true, plain: true },
);
const result = userDetails[1].dataValues;
delete result.password;
Expand Down
Loading