-
Notifications
You must be signed in to change notification settings - Fork 46
[FIX] - CarPlay #213
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
[FIX] - CarPlay #213
Conversation
Fix potential overrun in BM83ProcessEventCallerID. Fix potential missing 0-termination in BM83ProcessEventReadLinkedDeviceInformation.
…entiator when it is Voice Assistant talking or new call incoming. Fix Incoming constants typo.
Use Distance units from BMBT settings.
On reversing, display shortest distance to obstacle on IKE. Configurable in Settings -> Comfort. TODO: add BMBT screen display support TODO: add HIGH cluster display support
… to have consistent experience regardless of wall proximity. (eg do not delay the display until 1m / 40inch close).
…DIO/BMBT display yet.
…n, as well as manual date and time setting on radio.
[IMP] firmware: Reorder BT & IBUS context pointers in few structs to be same order and prevent accidental context pointer mistyping.
3c4d6a9 to
c9dfda5
Compare
* Configuration if CarPlay should be default on screen or OEM * Framework for explicitly requesting CarPlay screen on/off - for CP firmware that supports it * Make sure the playing screen if completely refreshed on return from CarPlay UI * Show CarPlay UI on active phone-call
c9dfda5 to
6c51666
Compare
|
Somehow, I guess the CarPlay stuff breaks the normal operation without CarPlay. At least I assume this breakes my MFL-operation. Is there now a configuration option to activate/deactivate CarPlay stuff? |
Yeah, I assume there are a lot of breaking changes in here. A configuration is a decent idea, but I feel like normies might think it magically adds CarPlay to the system and toggle it on anyways. I will see what I can do to carefully balance the integration :) -Ted |
|
This PR is not ready. I will push more commits he to review at once, but still there are few moments where states get out of sync. |
[IMP] On Calls and Siri switch to CarPlay screen [FIX] Improve state tracking for display switching [FIX] Improve screen data init after switching modes
|
As of now, this kind of expects CarPlay module to be there - so is not at all ready for general use without yet. |
|
Still some of the individual commits may be worth cherry picking into master. |
…le, show 99 or '--'
[FIX] Only control and use carplay functions when carplay enabled [IMP] Minor cleanups
…le, show 99 or '--'
Track the CarPlay state, redraw screen on return from CarPlay, ignore commands and keys handled by CarPlay.