Open
Conversation
Collaborator
|
This is awesome, Nihar, thanks a lot! I will check the code in detail over the next few days and merge if it looks OK. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implementation of the NRTidal correction to the already implemented IMRPhenomPv2 waveform model. This was for use in (https://arxiv.org/html/2407.09602v1). Note this is NRTidalv1 not NRTidalv2.
New files
🦓
waveforms/IMRPhenomPv2_NRTidal.pyThis file contains the implementation of the waveform model analogous to
waveforms/IMRPhenomD_NRTidalv2.py. I tried to avoid code duplication asmuch as possible, but I didn't want to touch
IMRPhenomPv2.pyso there is someduplication at the beginning of
gen_IMRPhenomPv2_NRTidal. Should this bechanged?
🦓
notebooks/check_IMRPv2_NRT.ipynbFollowing Thibeau's earlier PR, this file shows how one can call the waveform
model and checks that the taper, phase correction, and polarizations agree with
lalsimulation
Let me know if there is anything else which should be implemented.