Add aligned-spin conditions to PhenomPv2 angle calculations#36
Open
SSL32081 wants to merge 3 commits intotedwards2412:mainfrom
Open
Add aligned-spin conditions to PhenomPv2 angle calculations#36SSL32081 wants to merge 3 commits intotedwards2412:mainfrom
SSL32081 wants to merge 3 commits intotedwards2412:mainfrom
Conversation
thomasckng
suggested changes
Apr 15, 2025
thomasckng
left a comment
thomasckng
left a comment
There was a problem hiding this comment.
Not sure how unit tests work in this repo. Maybe just paste some test cases and results in this PR?
Author
Yeah, I'm thinking of pasting the tests I did here, but I’m not sure where to put them.
|
robkamcha
pushed a commit
to narolaharsh/ripple
that referenced
this pull request
Jan 12, 2026
…pple-dev/numpy-gte-1-and-lt-3 deps: update numpy requirement from <2,>=1 to >=1,<3
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds back the special treatments for two angles in the aligned-spin case implemented in
LALSimulationforPhenomPv2.These changes do not affect the behaviour of
PhenomPv2in most cases, and only in aligned-spin cases.Specifically, they are here in
LALSimulation:phiJ_sf: this line, andalpha0: this lineThis PR also fixes the apparent$\pi / 2$ phase shift mentioned in #35.