Open
Conversation
only thing there is now imports for waveforms
- Register new JaxNRSur waveform models in the codebase - Update tests to cover all waveform models, including TaylorF2 and IMRPhenom series - Comment out old NRSur tests for future reference
Collaborator
Author
|
I also cleaned up some typing inconsistency and moved files on the way. |
robkamcha
pushed a commit
to narolaharsh/ripple
that referenced
this pull request
Jan 12, 2026
…pple-dev/pymdown-extensions-10.17.2 deps: bump pymdown-extensions from 10.1 to 10.17.2
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces a high level interface for standardizing input and output across different waveform models. The original
gen_hphcinterface is still around so backward compatibility shouldn't be an issue. However, going forward we should favor the newWavefromModelinterface.