Add ContextValue version_cmp method tests for CentOS Stream and RHEL#291
Add ContextValue version_cmp method tests for CentOS Stream and RHEL#291junaruga wants to merge 1 commit intoteemtee:mainfrom
Conversation
1c85abe to
d9d8ba2
Compare
|
This just feels wrong. My understanding is that the current comparison works just because of the accident of string comparison. I would prefer if we can start work on #289, and instead define more explicitly how the context need to be ordered. |
|
@LecrisUT Thanks for your response. I think you are right. The name
I suppose that the Lines 159 to 161 in 39af408 However, while the comparing logic is to convert the version string to integer, there is already the document about the "fedora-33 < fedora-rawhide ---> True". And it seems the |
Add the test_version_cmp_centos_stream and test_version_cmp_rhel. The main purpose to add these tests are to make sure the `distro: centos-stream-rawhide` and `distro: rhel-10.rawhide` work.
d9d8ba2 to
30a4f52
Compare
|
It seems the CI testing-farm failures are not related to this PR. For example, for the testing-farm:fedora-rawhide-x86_64 case: https://artifacts.dev.testing-farm.io/8b1bb6af-012e-4798-87c2-58c1d092e346/ |
Add the test_version_cmp_centos_stream and test_version_cmp_rhel.
The main purpose to add these tests is to make sure the
distro: centos-stream-rawhideanddistro: rhel-X.rawhidesuch asdistro: rhel-10.rawhide,distro: rhel-9.rawhidework.Because I heard that the
distro: rhel-10.rawhideworkFor the documentation, there is the following document about the
fedora-rawahide. Let me know if you want to update the document with centos-stream and rhel.https://fmf.readthedocs.io/en/stable/context.html#context
https://github.com/teemtee/fmf/blob/39af408279b305bd8744e1a74c4ad09958394587/docs/context.rst#major-version
Checklist