Skip to content

Integration Tests and Improvements for repository-url provider#4490

Merged
happz merged 2 commits intomainfrom
vaibhav-dnf-repo-2
Jan 26, 2026
Merged

Integration Tests and Improvements for repository-url provider#4490
happz merged 2 commits intomainfrom
vaibhav-dnf-repo-2

Conversation

@vaibhavdaren
Copy link
Contributor

@vaibhavdaren vaibhavdaren commented Jan 15, 2026

Summary

  • Replace AssertionError with UnsupportedOperationError.
  • Add Integration Tests.

@vaibhavdaren vaibhavdaren added this to the 1.66 milestone Jan 15, 2026
@vaibhavdaren vaibhavdaren self-assigned this Jan 15, 2026
@vaibhavdaren vaibhavdaren added review | trivial Very easy for review, even for beginners, so don't be afraid to have a look! :-) plugin | artifact Related to the `prepare/artifact` plugin. labels Jan 15, 2026
@github-project-automation github-project-automation bot moved this to backlog in planning Jan 15, 2026
@vaibhavdaren vaibhavdaren moved this from backlog to implement in planning Jan 15, 2026
@happz happz added the status | blocked The merging of PR is blocked on some other issue label Jan 21, 2026
@happz
Copy link
Contributor

happz commented Jan 21, 2026

Blocked by #4505

@vaibhavdaren vaibhavdaren changed the base branch from main to vaibhav-priority-from-plugin-vars January 21, 2026 09:52
@vaibhavdaren vaibhavdaren force-pushed the vaibhav-dnf-repo-2 branch 3 times, most recently from 476a0ca to f16609b Compare January 21, 2026 15:10
@vaibhavdaren vaibhavdaren marked this pull request as ready for review January 21, 2026 15:11
@vaibhavdaren vaibhavdaren requested a review from LecrisUT January 22, 2026 09:37
Copy link
Contributor

@LecrisUT LecrisUT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor issues

@vaibhavdaren vaibhavdaren force-pushed the vaibhav-priority-from-plugin-vars branch from 091dc5c to 43bbeb2 Compare January 22, 2026 09:58
@vaibhavdaren vaibhavdaren force-pushed the vaibhav-dnf-repo-2 branch 3 times, most recently from b6b4a0d to 88ba90d Compare January 22, 2026 13:51
@vaibhavdaren vaibhavdaren moved this from implement to review in planning Jan 23, 2026
Base automatically changed from vaibhav-priority-from-plugin-vars to main January 23, 2026 12:20
@vaibhavdaren vaibhavdaren added ci | full test Pull request is ready for the full test execution and removed status | blocked The merging of PR is blocked on some other issue labels Jan 23, 2026
Copy link
Collaborator

@tcornell-bus tcornell-bus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM once cle's comments are addressed.

Copy link
Contributor

@psss psss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just two suggestions.

Add integration test for the repository-url artifact provider
following the same pattern as other provider tests. The test
verifies that packages can be installed from a repository
configured via baseurl and that the repository priority is
correctly set.
@psss psss changed the title Integration Tests and Improvements for repository-url provider Integration Tests and Improvements for repository-url provider Jan 26, 2026
Copy link
Contributor

@psss psss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the changes. Looks good, just two last nitpicks.

Copy link
Contributor

@AthreyVinay AthreyVinay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@psss psss moved this from review to merge in planning Jan 26, 2026
@psss
Copy link
Contributor

psss commented Jan 26, 2026

/packit build

@happz happz enabled auto-merge (squash) January 26, 2026 15:55
@happz happz merged commit a6de51c into main Jan 26, 2026
28 checks passed
@happz happz deleted the vaibhav-dnf-repo-2 branch January 26, 2026 19:28
@github-project-automation github-project-automation bot moved this from merge to done in planning Jan 26, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci | full test Pull request is ready for the full test execution plugin | artifact Related to the `prepare/artifact` plugin. review | trivial Very easy for review, even for beginners, so don't be afraid to have a look! :-)

Projects

Status: done

Development

Successfully merging this pull request may close these issues.

6 participants