Merged
Conversation
LecrisUT
added
code | no functional change
LecrisUT
added
the
status | blocking other work
LecrisUT
force-pushed
the
chore/refactor/beakerlib
branch
from
2add6e1 to
4b75480
Compare
![graphite-app[bot]](https://avatars.githubusercontent.com/in/158384?s=60&v=4){kind=small}
Contributor
|
This PR did not exist when the current sprint was planned this afternoon, and it does not refer to an issue planned for this sprint. What issue is this related to? |
Contributor
Author
It's precursor to #4440. |
LecrisUT
force-pushed
the
chore/refactor/beakerlib
branch
from
4b75480 to
a0c99c7
Compare
This was referenced Jan 16, 2026
psss
reviewed
Jan 19, 2026
Contributor
psss
left a comment
psss
left a comment
There was a problem hiding this comment.
Looks good to me. Actually, not good, rather much better with the nice structure instead of the many long if statements. Thanks a lot for refactoring this! Just three suggestions.
happz
reviewed
Jan 19, 2026
happz
reviewed
Jan 19, 2026
psss
approved these changes
Jan 21, 2026
Contributor
psss
left a comment
psss
left a comment
There was a problem hiding this comment.
Thanks for the changes, now looks good to me.
psss
force-pushed
the
chore/refactor/beakerlib
branch
from
bef50a3 to
f21a724
Compare
happz
reviewed
Jan 22, 2026
therazix
reviewed
Jan 23, 2026
LecrisUT
force-pushed
the
chore/refactor/beakerlib
branch
from
f21a724 to
62aff11
Compare
Signed-off-by: Cristian Le <git@lecris.dev>
Signed-off-by: Cristian Le <git@lecris.dev>
Signed-off-by: Cristian Le <git@lecris.dev>
Signed-off-by: Cristian Le <git@lecris.dev>
Signed-off-by: Cristian Le <git@lecris.dev>
Signed-off-by: Cristian Le <git@lecris.dev>
Signed-off-by: Cristian Le <git@lecris.dev>
Signed-off-by: Cristian Le <git@lecris.dev>
Signed-off-by: Cristian Le <git@lecris.dev>
Signed-off-by: Cristian Le <git@lecris.dev>
Signed-off-by: Cristian Le <git@lecris.dev>
Signed-off-by: Cristian Le <git@lecris.dev>
Signed-off-by: Cristian Le <git@lecris.dev>
happz
force-pushed
the
chore/refactor/beakerlib
branch
from
62aff11 to
82fe3ec
Compare
happz
approved these changes
Jan 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To summarize the changes here:
@container, moving all of the__init__andlibrary_factorylogic into a constructorcls.from_identifierBeakerLibclass into distinctBeakerLibUrlandBeakerLibPathwith more fine-grained type-checking__init__andfetchlogic inBeakerLibdepending on each type that it can beA precursor to #4440.
Pull Request Checklist