Fix FIPS prepare feature on CentOS Stream 8#4537
Fix FIPS prepare feature on CentOS Stream 8#4537The-Mule wants to merge 2 commits intoteemtee:mainfrom
Conversation
Python and Ansible versions on CentOS Stream 8 (ie. on RHEL-8 too) do no support dnf ansible module and we need to use command module to install the dependencies. Signed-off-by: Ondrej Moris <omoris@redhat.com>
Summary of ChangesHello @The-Mule, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request addresses a compatibility issue with FIPS preparation on CentOS Stream 8 (and RHEL 8) by adjusting the Ansible playbook. It ensures that necessary cryptographic policy packages are installed correctly on these systems, circumventing limitations with the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
The pull request successfully addresses the issue of dnf module incompatibility on CentOS Stream 8 by switching to the command module for RHEL8. This is a pragmatic workaround given the constraints. However, the changed_when condition for the command module task can be improved to ensure proper idempotency reporting.
Signed-off-by: Ondrej Moris <omoris@redhat.com>
|
/packit build |
tcornell-bus
left a comment
There was a problem hiding this comment.
LGTM, works when I target a rhel-8.10 machine
Python and Ansible versions on CentOS Stream 8 (ie. on RHEL-8 too) do no support dnf ansible module and we need to use command module to install the dependencies.
Pull Request Checklist