Skip to content

Fix FIPS prepare feature on CentOS Stream 8#4537

Open
The-Mule wants to merge 2 commits intoteemtee:mainfrom
The-Mule:fips-rhel-8-update
Open

Fix FIPS prepare feature on CentOS Stream 8#4537
The-Mule wants to merge 2 commits intoteemtee:mainfrom
The-Mule:fips-rhel-8-update

Conversation

@The-Mule
Copy link
Contributor

Python and Ansible versions on CentOS Stream 8 (ie. on RHEL-8 too) do no support dnf ansible module and we need to use command module to install the dependencies.

Pull Request Checklist

  • implement the feature
  • write the documentation
  • extend the test coverage
  • update the specification
  • adjust plugin docstring
  • modify the json schema
  • mention the version
  • include a release note

Python and Ansible versions on CentOS Stream 8 (ie. on RHEL-8 too)
do no support dnf ansible module and we need to use command
module to install the dependencies.

Signed-off-by: Ondrej Moris <omoris@redhat.com>
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @The-Mule, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses a compatibility issue with FIPS preparation on CentOS Stream 8 (and RHEL 8) by adjusting the Ansible playbook. It ensures that necessary cryptographic policy packages are installed correctly on these systems, circumventing limitations with the dnf Ansible module by directly executing dnf commands for RHEL 8 while maintaining module usage for RHEL 9.

Highlights

  • RHEL 8 FIPS preparation fix: Modified the FIPS preparation playbook to use the command module for installing dependencies on RHEL 8 (and CentOS Stream 8) due to dnf module compatibility issues with Python and Ansible versions on these systems.
  • RHEL 9 FIPS preparation: Separated the RHEL 9 FIPS dependency installation to continue using the dnf Ansible module, as it is compatible with RHEL 9, ensuring proper package management for newer versions.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

The pull request successfully addresses the issue of dnf module incompatibility on CentOS Stream 8 by switching to the command module for RHEL8. This is a pragmatic workaround given the constraints. However, the changed_when condition for the command module task can be improved to ensure proper idempotency reporting.

Signed-off-by: Ondrej Moris <omoris@redhat.com>
@LecrisUT LecrisUT added this to planning Feb 4, 2026
@github-project-automation github-project-automation bot moved this to backlog in planning Feb 4, 2026
@LecrisUT LecrisUT added the ci | full test Pull request is ready for the full test execution label Feb 4, 2026
@LecrisUT
Copy link
Contributor

LecrisUT commented Feb 4, 2026

/packit build

@LecrisUT LecrisUT moved this from backlog to review in planning Feb 4, 2026
@LecrisUT LecrisUT added the review | trivial Very easy for review, even for beginners, so don't be afraid to have a look! :-) label Feb 4, 2026
@thrix thrix self-requested a review February 4, 2026 19:35
Copy link
Collaborator

@tcornell-bus tcornell-bus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, works when I target a rhel-8.10 machine

@psss psss added this to the 1.68 milestone Feb 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci | full test Pull request is ready for the full test execution review | trivial Very easy for review, even for beginners, so don't be afraid to have a look! :-)

Projects

Status: review

Development

Successfully merging this pull request may close these issues.

4 participants