Enable eln container building & testing again

[psss]

Let's enable eln testing back when repos are in a good shape.
This reverts commit a425155 from #4552.

[gemini-code-assist]

Summary of Changes

Hello @psss, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request reactivates the eln container building and testing processes. By restoring the necessary configuration for fedora/eln images across the build system, it ensures that these tests can run again, following the stabilization of the underlying repositories. The primary impact is the re-integration of eln into the automated testing pipeline.

Highlights

• Re-enabling ELN Container Testing: This pull request re-enables the building and testing of eln containers, which were previously disabled.
• Revert of Previous Commit: The changes effectively revert commit a425155490c47a998770ec52fa08e3bf157e4b35, which had temporarily disabled eln testing.
• Makefile Updates: The Makefile has been updated to include fedora/eln:latest, fedora/eln/upstream:latest, and fedora/eln/unprivileged:latest in the list of TMT_TEST_CONTAINER_IMAGES.
• Test Image Script Modification: The tests/images.sh script now explicitly includes $TEST_IMAGE_PREFIX/fedora/eln:latest in the primary list of test images.

Changelog

• Makefile
  • Added fedora/eln:latest, fedora/eln/upstream:latest, and fedora/eln/unprivileged:latest to the TMT_TEST_CONTAINER_IMAGES variable.
  • Removed the commented-out block that previously disabled fedora/eln images and the associated TODO comment.
• tests/images.sh
  • Added $TEST_IMAGE_PREFIX/fedora/eln:latest to the list of primary test images.
  • Removed the commented-out block that previously disabled the fedora/eln image and the associated TODO comment.

Activity

• No specific activity (comments, reviews, etc.) has been recorded for this pull request yet.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request re-enables eln container building and testing. The changes in the Makefile correctly add the eln images back to the list of test images, and the commented-out code is cleanly removed. The change in tests/images.sh also re-enables the eln image for testing. I have one suggestion to improve consistency in the image variant used in tests/images.sh. Overall, the changes are straightforward and achieve the stated goal.

[gemini-code-assist]

For consistency with other Fedora and CentOS images in this list, which are upstream variants, consider using the upstream version of the eln image. Most other distribution images in TEST_CONTAINER_IMAGES use the upstream tag (e.g., fedora/42/upstream:latest, centos/stream10/upstream:latest). Using fedora/eln/upstream:latest here would align with that pattern.

This also makes the test suite more robust. If the upstream containerfile for eln is updated in the future to include more test-specific packages (as is common for other upstream images), this change will ensure those packages are included in the tests.

Suggested change

	$TEST_IMAGE_PREFIX/fedora/eln:latest
	$TEST_IMAGE_PREFIX/fedora/eln/upstream:latest

[psss]

That, actually, makes sense. @happz, what do you think? Both container files are currently identical, so currently it has not effect, but in general, it makes sense to consistently test against pure/unmodified upstream versions of the container, hm?