Skip to content

Move back bootc tests to fedora latest#4556

Open
bajertom wants to merge 1 commit intomainfrom
move-back-bootc-tests-to-fedora-latest
Open

Move back bootc tests to fedora latest#4556
bajertom wants to merge 1 commit intomainfrom
move-back-bootc-tests-to-fedora-latest

Conversation

@bajertom
Copy link
Contributor

@bajertom bajertom commented Feb 5, 2026

Pull Request Checklist

  • implement the feature
  • Investigate the avc failures

Reverts #4272

Similar to #4266

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @bajertom, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request reverts a temporary change that had pinned bootc tests to a specific Fedora 42 container image due to an AVC issue. The changes reconfigure the test suite to utilize the fedora/latest/bootc image, thereby aligning the test environment with the most current Fedora release and removing the now-obsolete Fedora 42 specific container build configurations.

Highlights

  • Revert Temporary Test Configuration: The bootc tests are now configured to use the fedora/latest container image, reverting a previous temporary pin to Fedora 42 that was in place due to an AVC issue.
  • Container Image Simplification: The specific build target and Containerfile for fedora/42/bootc have been removed, streamlining the container image build process.
  • Code Cleanup: Outdated TODO comments related to the temporary pinning of bootc tests to Fedora 42 have been removed from the relevant test scripts.
Changelog
  • Makefile
    • Removed the fedora/42/bootc:latest entry from the TMT_TEST_CONTAINER_IMAGES variable.
    • Deleted the Makefile target responsible for building the fedora/42/bootc:latest container image.
  • containers/fedora/42/bootc/Containerfile
    • The Containerfile used to define the fedora/42/bootc image has been removed.
  • tests/execute/tmt-scripts/main.fmf
    • Updated the IMAGE environment variable within the /fedora-bootc and /fedora-bootc-force test environments to point to localhost/tmt/container/test/fedora/latest/bootc:latest.
    • Removed the TODO comments indicating the temporary nature of the Fedora 42 image usage.
  • tests/execute/tmt-scripts/test.sh
    • Modified the build_container_image command to build fedora/latest/bootc:latest instead of fedora/42/bootc:latest.
    • Removed the TODO comment regarding the temporary image.
Activity
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@bajertom bajertom added this to planning Feb 5, 2026
@github-project-automation github-project-automation bot moved this to backlog in planning Feb 5, 2026
@bajertom bajertom moved this from backlog to implement in planning Feb 5, 2026
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request reverts a temporary change that pinned bootc tests to Fedora 42, moving them back to use fedora:latest. The changes are consistent across the Makefile, test configurations, and test scripts. The removal of the Fedora 42-specific bootc container file and its corresponding build rules is correct. The test configurations are correctly updated to use the latest bootc image. The changes are well-contained and accurately reflect the intention of the pull request.

@LecrisUT LecrisUT added the ci | full test Pull request is ready for the full test execution label Feb 6, 2026
@LecrisUT LecrisUT force-pushed the move-back-bootc-tests-to-fedora-latest branch from 2286527 to 57ef9bb Compare February 11, 2026 20:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci | full test Pull request is ready for the full test execution

Projects

Status: implement

Development

Successfully merging this pull request may close these issues.

2 participants