Skip to content

Upgrade supported Artemis API up to v0.0.84#4577

Open
happz wants to merge 5 commits intomainfrom
artemis-bump-to-84
Open

Upgrade supported Artemis API up to v0.0.84#4577
happz wants to merge 5 commits intomainfrom
artemis-bump-to-84

Conversation

@happz
Copy link
Contributor

@happz happz commented Feb 12, 2026

Pull Request Checklist

  • implement the feature

@happz happz added this to planning Feb 12, 2026
@happz happz added the plugin | artemis Related to Artemis provision plugin label Feb 12, 2026
@github-project-automation github-project-automation bot moved this to backlog in planning Feb 12, 2026
@happz happz moved this from backlog to review in planning Feb 12, 2026
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @happz, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request updates the tmt framework's Artemis provision step to support newer API versions, specifically 'v0.0.84' and 'v0.0.83'. This expansion of supported APIs enables the framework to leverage additional hardware requirement checks, enhancing the flexibility and capability of provisioning virtual machines with more specific hardware configurations.

Highlights

  • Artemis API Version Upgrade: The supported Artemis API versions have been updated to include 'v0.0.84' and 'v0.0.83'. This upgrade introduces support for new hardware requirements such as 'cpu.vendor', 'cpu.vendor-name', 'beaker.panic-watchdog', 'iommu', 'system.model-name', and generic 'device' requirements.
Changelog
  • tmt/steps/provision/artemis.py
    • Updated the SUPPORTED_API_VERSIONS tuple to include 'v0.0.84' and 'v0.0.83'.
    • Added comments detailing the new hardware requirements supported by these API versions.
Activity
  • The pull request author marked the 'implement the feature' checklist item as complete, indicating the core changes have been applied.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the supported Artemis API versions. My review focuses on two main points: ensuring version string consistency within SUPPORTED_API_VERSIONS and highlighting the need for version-gating for the newly supported hardware features to prevent issues with older Artemis instances. The implementation seems incomplete without these checks.

@psss psss added this to the 1.68 milestone Feb 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

plugin | artemis Related to Artemis provision plugin

Projects

Status: review

Development

Successfully merging this pull request may close these issues.

3 participants