Open
Conversation
This commit descibes some bad practices like DRY, Magic Numbers and Primitive Obsession.
The script should query the fork repository that the PR
originated from, otherwise some commits might not have
CI status and this script will throw an error, while the
user has pushed the commits one by one.
The `GITHUB_EVENT_PATH` environment variable points to a JSON
file that contains information about the pull request event,
including the user and repository information of the fork
repository.
This is an example of the JSON file:
```
{
"action": "opened",
"number": 4,
"pull_request": {
"_links": {
"comments": {
"href": "https://api.github.com/repos/realmarv/conventions/issues/4/comments"
},
"commits": {
"href": "https://api.github.com/repos/realmarv/conventions/pulls/4/commits"
},
"html": {
"href": "#4"
},
"issue": {
"href": "https://api.github.com/repos/realmarv/conventions/issues/4"
},
"review_comment": {
"href": "https://api.github.com/repos/realmarv/conventions/pulls/comments{/number}"
},
"review_comments": {
"href": "https://api.github.com/repos/realmarv/conventions/pulls/4/comments"
},
"self": {
"href": "https://api.github.com/repos/realmarv/conventions/pulls/4"
},
"statuses": {
"href": "https://api.github.com/repos/realmarv/conventions/statuses/c5eb50ea6c5a72d61ab85d96ffc66cc4741d3133"
}
},
"active_lock_reason": null,
"additions": 21,
"assignee": null,
"assignees": [],
"author_association": "OWNER",
"auto_merge": null,
"base": {
"label": "realmarv:master",
"ref": "master",
"repo": {
"allow_auto_merge": false,
"allow_forking": true,
"allow_merge_commit": true,
"allow_rebase_merge": true,
"allow_squash_merge": true,
"allow_update_branch": false,
"archive_url": "https://api.github.com/repos/realmarv/conventions/{archive_format}{/ref}",
"archived": false,
"assignees_url": "https://api.github.com/repos/realmarv/conventions/assignees{/user}",
"blobs_url": "https://api.github.com/repos/realmarv/conventions/git/blobs{/sha}",
"branches_url": "https://api.github.com/repos/realmarv/conventions/branches{/branch}",
"clone_url": "https://github.com/realmarv/conventions.git",
"collaborators_url": "https://api.github.com/repos/realmarv/conventions/collaborators{/collaborator}",
"comments_url": "https://api.github.com/repos/realmarv/conventions/comments{/number}",
"commits_url": "https://api.github.com/repos/realmarv/conventions/commits{/sha}",
"compare_url": "https://api.github.com/repos/realmarv/conventions/compare/{base}...{head}",
"contents_url": "https://api.github.com/repos/realmarv/conventions/contents/{+path}",
"contributors_url": "https://api.github.com/repos/realmarv/conventions/contributors",
"created_at": "2022-10-12T08:48:57Z",
"default_branch": "master",
"delete_branch_on_merge": false,
"deployments_url": "https://api.github.com/repos/realmarv/conventions/deployments",
"description": null,
"disabled": false,
"downloads_url": "https://api.github.com/repos/realmarv/conventions/downloads",
"events_url": "https://api.github.com/repos/realmarv/conventions/events",
"fork": true,
"forks": 0,
"forks_count": 0,
"forks_url": "https://api.github.com/repos/realmarv/conventions/forks",
"full_name": "realmarv/conventions",
"git_commits_url": "https://api.github.com/repos/realmarv/conventions/git/commits{/sha}",
"git_refs_url": "https://api.github.com/repos/realmarv/conventions/git/refs{/sha}",
"git_tags_url": "https://api.github.com/repos/realmarv/conventions/git/tags{/sha}",
"git_url": "git://github.com/realmarv/conventions.git",
"has_discussions": false,
"has_downloads": true,
"has_issues": false,
"has_pages": false,
"has_projects": true,
"has_wiki": true,
"homepage": null,
"hooks_url": "https://api.github.com/repos/realmarv/conventions/hooks",
"html_url": "https://github.com/realmarv/conventions",
"id": 550128772,
"is_template": false,
"issue_comment_url": "https://api.github.com/repos/realmarv/conventions/issues/comments{/number}",
"issue_events_url": "https://api.github.com/repos/realmarv/conventions/issues/events{/number}",
"issues_url": "https://api.github.com/repos/realmarv/conventions/issues{/number}",
"keys_url": "https://api.github.com/repos/realmarv/conventions/keys{/key_id}",
"labels_url": "https://api.github.com/repos/realmarv/conventions/labels{/name}",
"language": "TypeScript",
"languages_url": "https://api.github.com/repos/realmarv/conventions/languages",
"license": {
"key": "mit",
"name": "MIT License",
"node_id": "MDc6TGljZW5zZTEz",
"spdx_id": "MIT",
"url": "https://api.github.com/licenses/mit"
},
"merge_commit_message": "PR_TITLE",
"merge_commit_title": "MERGE_MESSAGE",
"merges_url": "https://api.github.com/repos/realmarv/conventions/merges",
"milestones_url": "https://api.github.com/repos/realmarv/conventions/milestones{/number}",
"mirror_url": null,
"name": "conventions",
"node_id": "R_kgDOIMpMhA",
"notifications_url": "https://api.github.com/repos/realmarv/conventions/notifications{?since,all,participating}",
"open_issues": 4,
"open_issues_count": 4,
"owner": {
"avatar_url": "https://avatars.githubusercontent.com/u/50144546?v=4",
"events_url": "https://api.github.com/users/realmarv/events{/privacy}",
"followers_url": "https://api.github.com/users/realmarv/followers",
"following_url": "https://api.github.com/users/realmarv/following{/other_user}",
"gists_url": "https://api.github.com/users/realmarv/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/realmarv",
"id": 50144546,
"login": "realmarv",
"node_id": "MDQ6VXNlcjUwMTQ0NTQ2",
"organizations_url": "https://api.github.com/users/realmarv/orgs",
"received_events_url": "https://api.github.com/users/realmarv/received_events",
"repos_url": "https://api.github.com/users/realmarv/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/realmarv/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/realmarv/subscriptions",
"type": "User",
"url": "https://api.github.com/users/realmarv"
},
"private": false,
"pulls_url": "https://api.github.com/repos/realmarv/conventions/pulls{/number}",
"pushed_at": "2023-03-23T09:00:26Z",
"releases_url": "https://api.github.com/repos/realmarv/conventions/releases{/id}",
"size": 2395,
"squash_merge_commit_message": "COMMIT_MESSAGES",
"squash_merge_commit_title": "COMMIT_OR_PR_TITLE",
"ssh_url": "git@github.com:realmarv/conventions.git",
"stargazers_count": 0,
"stargazers_url": "https://api.github.com/repos/realmarv/conventions/stargazers",
"statuses_url": "https://api.github.com/repos/realmarv/conventions/statuses/{sha}",
"subscribers_url": "https://api.github.com/repos/realmarv/conventions/subscribers",
"subscription_url": "https://api.github.com/repos/realmarv/conventions/subscription",
"svn_url": "https://github.com/realmarv/conventions",
"tags_url": "https://api.github.com/repos/realmarv/conventions/tags",
"teams_url": "https://api.github.com/repos/realmarv/conventions/teams",
"topics": [],
"trees_url": "https://api.github.com/repos/realmarv/conventions/git/trees{/sha}",
"updated_at": "2022-10-13T08:53:39Z",
"url": "https://api.github.com/repos/realmarv/conventions",
"use_squash_pr_title_as_default": false,
"visibility": "public",
"watchers": 0,
"watchers_count": 0,
"web_commit_signoff_required": false
},
"sha": "0be2f2d608cdf893e146db1296dee750a2a54cfc",
"user": {
"avatar_url": "https://avatars.githubusercontent.com/u/50144546?v=4",
"events_url": "https://api.github.com/users/realmarv/events{/privacy}",
"followers_url": "https://api.github.com/users/realmarv/followers",
"following_url": "https://api.github.com/users/realmarv/following{/other_user}",
"gists_url": "https://api.github.com/users/realmarv/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/realmarv",
"id": 50144546,
"login": "realmarv",
"node_id": "MDQ6VXNlcjUwMTQ0NTQ2",
"organizations_url": "https://api.github.com/users/realmarv/orgs",
"received_events_url": "https://api.github.com/users/realmarv/received_events",
"repos_url": "https://api.github.com/users/realmarv/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/realmarv/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/realmarv/subscriptions",
"type": "User",
"url": "https://api.github.com/users/realmarv"
}
},
"body": null,
"changed_files": 2,
"closed_at": null,
"comments": 0,
"comments_url": "https://api.github.com/repos/realmarv/conventions/issues/4/comments",
"commits": 2,
"commits_url": "https://api.github.com/repos/realmarv/conventions/pulls/4/commits",
"created_at": "2023-03-23T09:00:26Z",
"deletions": 0,
"diff_url": "https://github.com/realmarv/conventions/pull/4.diff",
"draft": false,
"head": {
"label": "realmarv:fixGitPush1by1Check",
"ref": "fixGitPush1by1Check",
"repo": {
"allow_auto_merge": false,
"allow_forking": true,
"allow_merge_commit": true,
"allow_rebase_merge": true,
"allow_squash_merge": true,
"allow_update_branch": false,
"archive_url": "https://api.github.com/repos/realmarv/conventions/{archive_format}{/ref}",
"archived": false,
"assignees_url": "https://api.github.com/repos/realmarv/conventions/assignees{/user}",
"blobs_url": "https://api.github.com/repos/realmarv/conventions/git/blobs{/sha}",
"branches_url": "https://api.github.com/repos/realmarv/conventions/branches{/branch}",
"clone_url": "https://github.com/realmarv/conventions.git",
"collaborators_url": "https://api.github.com/repos/realmarv/conventions/collaborators{/collaborator}",
"comments_url": "https://api.github.com/repos/realmarv/conventions/comments{/number}",
"commits_url": "https://api.github.com/repos/realmarv/conventions/commits{/sha}",
"compare_url": "https://api.github.com/repos/realmarv/conventions/compare/{base}...{head}",
"contents_url": "https://api.github.com/repos/realmarv/conventions/contents/{+path}",
"contributors_url": "https://api.github.com/repos/realmarv/conventions/contributors",
"created_at": "2022-10-12T08:48:57Z",
"default_branch": "master",
"delete_branch_on_merge": false,
"deployments_url": "https://api.github.com/repos/realmarv/conventions/deployments",
"description": null,
"disabled": false,
"downloads_url": "https://api.github.com/repos/realmarv/conventions/downloads",
"events_url": "https://api.github.com/repos/realmarv/conventions/events",
"fork": true,
"forks": 0,
"forks_count": 0,
"forks_url": "https://api.github.com/repos/realmarv/conventions/forks",
"full_name": "realmarv/conventions",
"git_commits_url": "https://api.github.com/repos/realmarv/conventions/git/commits{/sha}",
"git_refs_url": "https://api.github.com/repos/realmarv/conventions/git/refs{/sha}",
"git_tags_url": "https://api.github.com/repos/realmarv/conventions/git/tags{/sha}",
"git_url": "git://github.com/realmarv/conventions.git",
"has_discussions": false,
"has_downloads": true,
"has_issues": false,
"has_pages": false,
"has_projects": true,
"has_wiki": true,
"homepage": null,
"hooks_url": "https://api.github.com/repos/realmarv/conventions/hooks",
"html_url": "https://github.com/realmarv/conventions",
"id": 550128772,
"is_template": false,
"issue_comment_url": "https://api.github.com/repos/realmarv/conventions/issues/comments{/number}",
"issue_events_url": "https://api.github.com/repos/realmarv/conventions/issues/events{/number}",
"issues_url": "https://api.github.com/repos/realmarv/conventions/issues{/number}",
"keys_url": "https://api.github.com/repos/realmarv/conventions/keys{/key_id}",
"labels_url": "https://api.github.com/repos/realmarv/conventions/labels{/name}",
"language": "TypeScript",
"languages_url": "https://api.github.com/repos/realmarv/conventions/languages",
"license": {
"key": "mit",
"name": "MIT License",
"node_id": "MDc6TGljZW5zZTEz",
"spdx_id": "MIT",
"url": "https://api.github.com/licenses/mit"
},
"merge_commit_message": "PR_TITLE",
"merge_commit_title": "MERGE_MESSAGE",
"merges_url": "https://api.github.com/repos/realmarv/conventions/merges",
"milestones_url": "https://api.github.com/repos/realmarv/conventions/milestones{/number}",
"mirror_url": null,
"name": "conventions",
"node_id": "R_kgDOIMpMhA",
"notifications_url": "https://api.github.com/repos/realmarv/conventions/notifications{?since,all,participating}",
"open_issues": 4,
"open_issues_count": 4,
"owner": {
"avatar_url": "https://avatars.githubusercontent.com/u/50144546?v=4",
"events_url": "https://api.github.com/users/realmarv/events{/privacy}",
"followers_url": "https://api.github.com/users/realmarv/followers",
"following_url": "https://api.github.com/users/realmarv/following{/other_user}",
"gists_url": "https://api.github.com/users/realmarv/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/realmarv",
"id": 50144546,
"login": "realmarv",
"node_id": "MDQ6VXNlcjUwMTQ0NTQ2",
"organizations_url": "https://api.github.com/users/realmarv/orgs",
"received_events_url": "https://api.github.com/users/realmarv/received_events",
"repos_url": "https://api.github.com/users/realmarv/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/realmarv/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/realmarv/subscriptions",
"type": "User",
"url": "https://api.github.com/users/realmarv"
},
"private": false,
"pulls_url": "https://api.github.com/repos/realmarv/conventions/pulls{/number}",
"pushed_at": "2023-03-23T09:00:26Z",
"releases_url": "https://api.github.com/repos/realmarv/conventions/releases{/id}",
"size": 2395,
"squash_merge_commit_message": "COMMIT_MESSAGES",
"squash_merge_commit_title": "COMMIT_OR_PR_TITLE",
"ssh_url": "git@github.com:realmarv/conventions.git",
"stargazers_count": 0,
"stargazers_url": "https://api.github.com/repos/realmarv/conventions/stargazers",
"statuses_url": "https://api.github.com/repos/realmarv/conventions/statuses/{sha}",
"subscribers_url": "https://api.github.com/repos/realmarv/conventions/subscribers",
"subscription_url": "https://api.github.com/repos/realmarv/conventions/subscription",
"svn_url": "https://github.com/realmarv/conventions",
"tags_url": "https://api.github.com/repos/realmarv/conventions/tags",
"teams_url": "https://api.github.com/repos/realmarv/conventions/teams",
"topics": [],
"trees_url": "https://api.github.com/repos/realmarv/conventions/git/trees{/sha}",
"updated_at": "2022-10-13T08:53:39Z",
"url": "https://api.github.com/repos/realmarv/conventions",
"use_squash_pr_title_as_default": false,
"visibility": "public",
"watchers": 0,
"watchers_count": 0,
"web_commit_signoff_required": false
},
"sha": "c5eb50ea6c5a72d61ab85d96ffc66cc4741d3133",
"user": {
"avatar_url": "https://avatars.githubusercontent.com/u/50144546?v=4",
"events_url": "https://api.github.com/users/realmarv/events{/privacy}",
"followers_url": "https://api.github.com/users/realmarv/followers",
"following_url": "https://api.github.com/users/realmarv/following{/other_user}",
"gists_url": "https://api.github.com/users/realmarv/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/realmarv",
"id": 50144546,
"login": "realmarv",
"node_id": "MDQ6VXNlcjUwMTQ0NTQ2",
"organizations_url": "https://api.github.com/users/realmarv/orgs",
"received_events_url": "https://api.github.com/users/realmarv/received_events",
"repos_url": "https://api.github.com/users/realmarv/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/realmarv/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/realmarv/subscriptions",
"type": "User",
"url": "https://api.github.com/users/realmarv"
}
},
"html_url": "#4",
"id": 1287033164,
"issue_url": "https://api.github.com/repos/realmarv/conventions/issues/4",
"labels": [],
"locked": false,
"maintainer_can_modify": false,
"merge_commit_sha": null,
"mergeable": null,
"mergeable_state": "unknown",
"merged": false,
"merged_at": null,
"merged_by": null,
"milestone": null,
"node_id": "PR_kwDOIMpMhM5MtpFM",
"number": 4,
"patch_url": "https://github.com/realmarv/conventions/pull/4.patch",
"rebaseable": null,
"requested_reviewers": [],
"requested_teams": [],
"review_comment_url": "https://api.github.com/repos/realmarv/conventions/pulls/comments{/number}",
"review_comments": 0,
"review_comments_url": "https://api.github.com/repos/realmarv/conventions/pulls/4/comments",
"state": "open",
"statuses_url": "https://api.github.com/repos/realmarv/conventions/statuses/c5eb50ea6c5a72d61ab85d96ffc66cc4741d3133",
"title": "Fix git push1by1 check",
"updated_at": "2023-03-23T09:00:26Z",
"url": "https://api.github.com/repos/realmarv/conventions/pulls/4",
"user": {
"avatar_url": "https://avatars.githubusercontent.com/u/50144546?v=4",
"events_url": "https://api.github.com/users/realmarv/events{/privacy}",
"followers_url": "https://api.github.com/users/realmarv/followers",
"following_url": "https://api.github.com/users/realmarv/following{/other_user}",
"gists_url": "https://api.github.com/users/realmarv/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/realmarv",
"id": 50144546,
"login": "realmarv",
"node_id": "MDQ6VXNlcjUwMTQ0NTQ2",
"organizations_url": "https://api.github.com/users/realmarv/orgs",
"received_events_url": "https://api.github.com/users/realmarv/received_events",
"repos_url": "https://api.github.com/users/realmarv/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/realmarv/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/realmarv/subscriptions",
"type": "User",
"url": "https://api.github.com/users/realmarv"
}
},
"repository": {
"allow_forking": true,
"archive_url": "https://api.github.com/repos/realmarv/conventions/{archive_format}{/ref}",
"archived": false,
"assignees_url": "https://api.github.com/repos/realmarv/conventions/assignees{/user}",
"blobs_url": "https://api.github.com/repos/realmarv/conventions/git/blobs{/sha}",
"branches_url": "https://api.github.com/repos/realmarv/conventions/branches{/branch}",
"clone_url": "https://github.com/realmarv/conventions.git",
"collaborators_url": "https://api.github.com/repos/realmarv/conventions/collaborators{/collaborator}",
"comments_url": "https://api.github.com/repos/realmarv/conventions/comments{/number}",
"commits_url": "https://api.github.com/repos/realmarv/conventions/commits{/sha}",
"compare_url": "https://api.github.com/repos/realmarv/conventions/compare/{base}...{head}",
"contents_url": "https://api.github.com/repos/realmarv/conventions/contents/{+path}",
"contributors_url": "https://api.github.com/repos/realmarv/conventions/contributors",
"created_at": "2022-10-12T08:48:57Z",
"default_branch": "master",
"deployments_url": "https://api.github.com/repos/realmarv/conventions/deployments",
"description": null,
"disabled": false,
"downloads_url": "https://api.github.com/repos/realmarv/conventions/downloads",
"events_url": "https://api.github.com/repos/realmarv/conventions/events",
"fork": true,
"forks": 0,
"forks_count": 0,
"forks_url": "https://api.github.com/repos/realmarv/conventions/forks",
"full_name": "realmarv/conventions",
"git_commits_url": "https://api.github.com/repos/realmarv/conventions/git/commits{/sha}",
"git_refs_url": "https://api.github.com/repos/realmarv/conventions/git/refs{/sha}",
"git_tags_url": "https://api.github.com/repos/realmarv/conventions/git/tags{/sha}",
"git_url": "git://github.com/realmarv/conventions.git",
"has_discussions": false,
"has_downloads": true,
"has_issues": false,
"has_pages": false,
"has_projects": true,
"has_wiki": true,
"homepage": null,
"hooks_url": "https://api.github.com/repos/realmarv/conventions/hooks",
"html_url": "https://github.com/realmarv/conventions",
"id": 550128772,
"is_template": false,
"issue_comment_url": "https://api.github.com/repos/realmarv/conventions/issues/comments{/number}",
"issue_events_url": "https://api.github.com/repos/realmarv/conventions/issues/events{/number}",
"issues_url": "https://api.github.com/repos/realmarv/conventions/issues{/number}",
"keys_url": "https://api.github.com/repos/realmarv/conventions/keys{/key_id}",
"labels_url": "https://api.github.com/repos/realmarv/conventions/labels{/name}",
"language": "TypeScript",
"languages_url": "https://api.github.com/repos/realmarv/conventions/languages",
"license": {
"key": "mit",
"name": "MIT License",
"node_id": "MDc6TGljZW5zZTEz",
"spdx_id": "MIT",
"url": "https://api.github.com/licenses/mit"
},
"merges_url": "https://api.github.com/repos/realmarv/conventions/merges",
"milestones_url": "https://api.github.com/repos/realmarv/conventions/milestones{/number}",
"mirror_url": null,
"name": "conventions",
"node_id": "R_kgDOIMpMhA",
"notifications_url": "https://api.github.com/repos/realmarv/conventions/notifications{?since,all,participating}",
"open_issues": 4,
"open_issues_count": 4,
"owner": {
"avatar_url": "https://avatars.githubusercontent.com/u/50144546?v=4",
"events_url": "https://api.github.com/users/realmarv/events{/privacy}",
"followers_url": "https://api.github.com/users/realmarv/followers",
"following_url": "https://api.github.com/users/realmarv/following{/other_user}",
"gists_url": "https://api.github.com/users/realmarv/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/realmarv",
"id": 50144546,
"login": "realmarv",
"node_id": "MDQ6VXNlcjUwMTQ0NTQ2",
"organizations_url": "https://api.github.com/users/realmarv/orgs",
"received_events_url": "https://api.github.com/users/realmarv/received_events",
"repos_url": "https://api.github.com/users/realmarv/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/realmarv/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/realmarv/subscriptions",
"type": "User",
"url": "https://api.github.com/users/realmarv"
},
"private": false,
"pulls_url": "https://api.github.com/repos/realmarv/conventions/pulls{/number}",
"pushed_at": "2023-03-23T09:00:26Z",
"releases_url": "https://api.github.com/repos/realmarv/conventions/releases{/id}",
"size": 2395,
"ssh_url": "git@github.com:realmarv/conventions.git",
"stargazers_count": 0,
"stargazers_url": "https://api.github.com/repos/realmarv/conventions/stargazers",
"statuses_url": "https://api.github.com/repos/realmarv/conventions/statuses/{sha}",
"subscribers_url": "https://api.github.com/repos/realmarv/conventions/subscribers",
"subscription_url": "https://api.github.com/repos/realmarv/conventions/subscription",
"svn_url": "https://github.com/realmarv/conventions",
"tags_url": "https://api.github.com/repos/realmarv/conventions/tags",
"teams_url": "https://api.github.com/repos/realmarv/conventions/teams",
"topics": [],
"trees_url": "https://api.github.com/repos/realmarv/conventions/git/trees{/sha}",
"updated_at": "2022-10-13T08:53:39Z",
"url": "https://api.github.com/repos/realmarv/conventions",
"visibility": "public",
"watchers": 0,
"watchers_count": 0,
"web_commit_signoff_required": false
},
"sender": {
"avatar_url": "https://avatars.githubusercontent.com/u/50144546?v=4",
"events_url": "https://api.github.com/users/realmarv/events{/privacy}",
"followers_url": "https://api.github.com/users/realmarv/followers",
"following_url": "https://api.github.com/users/realmarv/following{/other_user}",
"gists_url": "https://api.github.com/users/realmarv/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/realmarv",
"id": 50144546,
"login": "realmarv",
"node_id": "MDQ6VXNlcjUwMTQ0NTQ2",
"organizations_url": "https://api.github.com/users/realmarv/orgs",
"received_events_url": "https://api.github.com/users/realmarv/received_events",
"repos_url": "https://api.github.com/users/realmarv/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/realmarv/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/realmarv/subscriptions",
"type": "User",
"url": "https://api.github.com/users/realmarv"
}
}
```
Improve the detectNotUsingGitPush1by1.fsx script to detect wrong CI status of commits. If commit msg contains text "failing test", then it would be allowed to have broken CI, else CI should be green. Fixes nblockchain#95
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.