Skip to content

Bias buffer is not getting correct configuration in script in case of measure function is selected as combine #32

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 23, 2025
Merged

Bias buffer is not getting correct configuration in script in case of measure function is selected as combine #32

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion script-gen-manager/src/instr_metadata/base_metadata.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ impl BaseMetadata {
//TODO: verify this value for Trebuchet
pub const EPSILON: f64 = 1e-9;
//TODO: verify this value for Trebuchet
pub const MIN_LOG_VALUE: f64 = 1e-12;
pub const MIN_LOG_VALUE: f64 = 5e-6;
//TODO: verify this value for Trebuchet
pub const MIN_BUFFER_TIME: f64 = 60e-6;

Expand Down
8 changes: 4 additions & 4 deletions xml-handler/src/resources/sweep/MP5000Sweep.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,7 +95,7 @@

---@class Measure
---@field nplc number | nil
---@field aperature number | nil
---@field aperture number | nil
---@field rate `CONSTANTS.RATE_FAST` | `CONSTANTS.RATE_NORMAL` | nil
-- ---@field autozero boolean Whether autozero should be turned on or not
---@field count integer The number of measurments to take
Expand Down Expand Up @@ -382,8 +382,8 @@
-- nplc
if self.measure.nplc ~= nil then
self.channel.measure.nplc = self.measure.nplc
elseif self.measure.aperature ~= nil then
self.channel.measure.aperature = self.measure.aperature
elseif self.measure.aperture ~= nil then
self.channel.measure.aperture = self.measure.aperture
end
-- count
self.channel.measure.count = self.measure.count
Expand Down Expand Up @@ -1353,7 +1353,7 @@
<condition name="BIAS-DEVICE:MFUNCTION">FUNC_DC_IV_COMBINED</condition>
<snippet>
{
buffer = %NODE%.slot[%BIAS-DEVICE:SLOT-IDX%].%MODEL-TYPE%[%BIAS-DEVICE:CHANNEL-IDX%].defbuffer1,
buffer = %NODE%.slot[%SLOT-IDX%].%MODEL-TYPE%[%CHANNEL-IDX%].defbuffer1,
type = CONSTANTS.FUNC_DC_CURRENT
},
{
Expand Down
Loading