Handle parameters in data urls (follow up PR) #13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NBIX-Mark-Southern
force-pushed
the
feature_parameters
branch
from
d196bab to
975a878
Compare
NBIX-Mark-Southern
force-pushed
the
feature_parameters
branch
from
975a878 to
c55cb83
Compare
Contributor
Author
|
Hey @telday , I almost forgot about this one. Do you want to revisit? |
Owner
@NBIX-Mark-Southern Yes! I apologize for the long turnaround on this one. I'm finishing up a move in the next couple days and will have time to take a look next week. |
telday
approved these changes
Jul 14, 2025
Owner
telday
left a comment
telday
left a comment
There was a problem hiding this comment.
Thanks for the contribution. I will be drafting anew release of the project this week with your last two PR's and a few other changes!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✨ Changes
❗ Downstream of the feature_from_url PR. Merge that first.
Adds the ability to parse and reconstruct parameters in data urls. Parameter values can be url encoded.
E.g.
data:text/plain;charset=iso-8859-7,%be%fg%be...Definitions from: