Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Całość zadania zajęło mi około 3h (2h zrobienie żeby działało i 1h dopieszczanie i refaktor)
Oczywiście pomagałem sobie ai bo sam bym zrobił to tak samo, ale o wiele dłużej
Starałem się trzymać dobrych zasad programowania tj. clean architecture, SOLID, wzorce, testy itp
Myślę, że to co chciałem wspomnieć wspomniałem na video, może nie wspomniałem o podstawach tj. robienie interfejsów z dependency injection ale jak są testy i mockowanie to raczej to oczywiste.