Skip to content

Edit files in the user's preferred application if possible #215

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dhleong wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Edit files in the user's preferred application if possible #215

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 22 additions & 8 deletions Vimari Extension/ConfigurationModel.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,18 +30,32 @@ class ConfigurationModel: ConfigurationModelProtocol {

func editConfigFile() throws {
let settingsFilePath = try findOrCreateUserSettings()
NSWorkspace.shared.openFile(
settingsFilePath,
withApplication: Constant.defaultEditor
)
openFileInPreferredEditor(filePath: settingsFilePath)
}

func resetConfigFile() throws {
let settingsFilePath = try overwriteUserSettings()
NSWorkspace.shared.openFile(
settingsFilePath,
withApplication: Constant.defaultEditor
)
openFileInPreferredEditor(filePath: settingsFilePath)
}

func openFileInPreferredEditor(filePath: String) {
let fileUrl = URL(fileURLWithPath: filePath)
let app = NSWorkspace.shared.urlForApplication(toOpen: fileUrl)

if #available(OSXApplicationExtension 10.15, *), let app = app {
NSLog("opening \(fileUrl) with \(String(describing: app))")

let config = NSWorkspace.OpenConfiguration()
config.promptsUserIfNeeded = true

NSWorkspace.shared.open([fileUrl], withApplicationAt: app, configuration: config, completionHandler: nil)
} else {
// Fallback on earlier versions
NSWorkspace.shared.openFile(
filePath,
withApplication: Constant.defaultEditor
)
}
}

func getDefaultSettings() throws -> [String : Any] {
Expand Down