Skip to content

Conversation

@hugoh
Copy link

@hugoh hugoh commented Jul 25, 2021

Given the number of questions/issues about excludedUrls (#234, #225) and also the fact that the matching is pretty crude, here's a proposed PR for an excludedUrlsRegex setting which should be more straightforward for users familiar with regular expressions.

"excludedUrls": "a.com,b.com",

can be encoded as

"excludedUrlsRegex": "^https?://(a|b)\.com/",

and whether or not foo.a.com is matched or not can now be controlled with the setting above (not matching) or the setting below (matching):

"excludedUrlsRegex": "^https?://([^/]+\.)?(a|b)\.com/",

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant