Skip to content

Conversation

@chaptersix
Copy link

@chaptersix chaptersix commented Oct 22, 2025

What changed?
Add a token Field to the Callback message.

Why?
Allows the SDK to explicitly attach the New Nexus Callback Token to a Callback.
ATTACH PROPOSAL HERE

Breaking changes
no breaking changes.

Copy link
Member

@bergundy bergundy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved with comments.

Co-authored-by: Roey Berman <roey.berman@gmail.com>
@chaptersix chaptersix marked this pull request as ready for review November 17, 2025 15:31
@chaptersix chaptersix requested review from a team as code owners November 17, 2025 15:31
map<string, string> header = 2;
// A token that is used to recreated context when handling the callback request.
// Supported from server version 1.30.
bytes token = 3;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not understanding this necessarily. I see "ATTACH PROPOSAL HERE" in the description. Can you clarify this from the description:

Allows the SDK to explicitly attach the New Nexus Callback Token to a Callback.

What do SDKs need to do?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

my bad, forgot to move it back to draft. I'll share a proposal soon to clarify

@chaptersix chaptersix marked this pull request as draft November 17, 2025 18:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants