-
Notifications
You must be signed in to change notification settings - Fork 78
add token to callback.nexus #652
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
bergundy
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved with comments.
Co-authored-by: Roey Berman <roey.berman@gmail.com>
| map<string, string> header = 2; | ||
| // A token that is used to recreated context when handling the callback request. | ||
| // Supported from server version 1.30. | ||
| bytes token = 3; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not understanding this necessarily. I see "ATTACH PROPOSAL HERE" in the description. Can you clarify this from the description:
Allows the SDK to explicitly attach the New Nexus Callback Token to a Callback.
What do SDKs need to do?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
my bad, forgot to move it back to draft. I'll share a proposal soon to clarify
What changed?
Add a token Field to the Callback message.
Why?
Allows the SDK to explicitly attach the New Nexus Callback Token to a Callback.
ATTACH PROPOSAL HERE
Breaking changes
no breaking changes.