Skip to content

fix: remove custom error #1598

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix: remove custom error #1598

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b7cc833
fix: remove custom error
albertlai431 Jan 14, 2025
5f8d4b7
Merge branch 'main' into main
mjameswh Jan 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 2 additions & 10 deletions packages/common/src/internal-non-workflow/data-converter-helpers.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
import { PayloadConverter, defaultPayloadConverter } from '../converter/payload-converter';
import { DataConverter, defaultFailureConverter, LoadedDataConverter } from '../converter/data-converter';
import { FailureConverter } from '../converter/failure-converter';
import { errorCode, hasOwnProperty, isRecord } from '../type-helpers';
import { hasOwnProperty, isRecord } from '../type-helpers';
import { ValueError } from '../errors';

const isValidPayloadConverter = (converter: unknown, path: string): asserts converter is PayloadConverter => {
Expand Down Expand Up @@ -35,15 +35,7 @@ function requireConverter<T>(
type: string,
validator: (converter: unknown, path: string) => asserts converter is T
): T {
let module;
try {
module = require(path); // eslint-disable-line @typescript-eslint/no-require-imports
} catch (error) {
if (errorCode(error) === 'MODULE_NOT_FOUND') {
throw new ValueError(`Could not find a file at the specified ${type}Path: '${path}'.`);
}
throw error;
}
const module = require(path); // eslint-disable-line @typescript-eslint/no-require-imports

if (isRecord(module) && hasOwnProperty(module, type)) {
const converter = module[type];
Expand Down
Loading