Don't set error status on otel spans for benign exceptions #1786
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tconley1428
approved these changes
Sep 22, 2025
packages/test/package.json
Outdated
| "test": "ava ./lib/test-*.js", | ||
| "test.watch": "ava --watch ./lib/test-*.js" | ||
| "test.watch": "ava --watch ./lib/test-*.js", | ||
| "test-otel": "ava ./lib/test-otel.js" |
There was a problem hiding this comment.
Does otel seem important enough to have this separately, or was this a during development thing?
There was a problem hiding this comment.
Does otel seem important enough to have this separately,
No. I'd prefer we don't add such things.
There was a problem hiding this comment.
development thing - i'll remove
mjameswh
reviewed
Sep 22, 2025
| if (acceptableErrors === undefined || !acceptableErrors(err)) { | ||
| span.setStatus({ code: otel.SpanStatusCode.ERROR, message: err instanceof Error ? err.message : String(err) }); | ||
| const statusCode = isBenignErr ? otel.SpanStatusCode.UNSET : otel.SpanStatusCode.ERROR; | ||
| span.setStatus({ code: statusCode, message: err instanceof Error ? err.message : String(err) }); |
There was a problem hiding this comment.
Being an Error is neither necessary nor sufficient to deduce that message will be present. Prefer this instead:
Suggested change
| span.setStatus({ code: statusCode, message: err instanceof Error ? err.message : String(err) }); | |
| span.setStatus({ code: statusCode, message: (err as Error).message ?? String(err) }); |
mjameswh
approved these changes
Sep 22, 2025
|
merging - ci failing on unrelated failures |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was changed
DWISOTT
Why?
We don't want benign exceptions to alert failures
Closes [Feature Request] Reclassify Benign Application errors in OpenTelemetry #1776
How was this tested:
Integration test
Any docs updates needed?
Don't think so