Skip to content

remove gcpsink ff check #440

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jumbogo wants to merge 1 commit into
base: main
Choose a base branch
from
Open

remove gcpsink ff check #440

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 2 additions & 5 deletions app/namespace.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2023,11 +2023,8 @@ func NewNamespaceCommand(getNamespaceClientFn GetNamespaceClientFn) (CommandOut,
exportS3Commands.Subcommands = append(exportS3Commands.Subcommands, exportGeneralCommands...)
exportCommand.Subcommands = append(exportCommand.Subcommands, exportS3Commands)

// TODO: remove GCP sink feature flag check when out of pre-release
if IsFeatureEnabled(GCPSinkFeatureFlag) {
exportGCSCommands.Subcommands = append(exportGCSCommands.Subcommands, exportGeneralCommands...)
exportCommand.Subcommands = append(exportCommand.Subcommands, exportGCSCommands)
}
exportGCSCommands.Subcommands = append(exportGCSCommands.Subcommands, exportGeneralCommands...)
Copy link
Contributor

@yux0 yux0 Apr 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will this append the General commands twice?

Copy link
Contributor Author

@jumbogo jumbogo Apr 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

They are under different sub commands? s3 vs gcs

exportCommand.Subcommands = append(exportCommand.Subcommands, exportGCSCommands)

subCommands = append(subCommands, exportCommand)

Expand Down