Closed
Conversation
anekkanti
previously approved these changes
Feb 10, 2026
anekkanti
reviewed
Feb 10, 2026
go.mod
Outdated
| require ( | ||
| buf.build/gen/go/bufbuild/protovalidate/protocolbuffers/go v1.36.11-20260209202127-80ab13bee0bf.1 | ||
| github.com/go-playground/validator/v10 v10.13.0 | ||
| github.com/gogo/protobuf v1.3.2 |
Member
There was a problem hiding this comment.
I would have expected this to go away.
Member
There was a problem hiding this comment.
I think we should remove all references to gogo.
anekkanti
dismissed
their stale review
I think we have more work to do.
We need to remove all references to gogo.
anekkanti
reviewed
Feb 10, 2026
Comment on lines
+34
to
+45
| if pm, ok := m.(proto.Message); ok { | ||
| marshaler := protojson.MarshalOptions{ | ||
| Indent: "\t", | ||
| EmitUnpopulated: true, | ||
| } | ||
| b, err := marshaler.Marshal(pm) | ||
| if err != nil { | ||
| return "", err | ||
| } | ||
| return string(b), nil | ||
| } | ||
| b, err := json.MarshalIndent(m, "", "\t") |
Member
There was a problem hiding this comment.
Will the protojson produce the similar output as jsonpb?
If not this backward incompatible and effects all outputs by tcld.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was changed
Why?
Checklist
Closes
How was this tested: