-
Notifications
You must be signed in to change notification settings - Fork 36
doc: release policy and versioning #288
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
jaypipes
wants to merge
1
commit into
temporalio:main
Choose a base branch
from
jaypipes:jaypipes/version-docs
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+65
−0
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,64 @@ | ||
| # Releases | ||
|
|
||
| This document explains our thinking around Releases of Temporal Worker | ||
| Controller and associated Helm Charts. | ||
|
|
||
| A Release is a coordination point for publishing a versioned set of artifacts. | ||
| Each Release has a Github Release page which describes the changes in the | ||
| Release and the artifacts associated with it. | ||
|
|
||
| A Release Tag is simply the string name given to the Release. | ||
|
|
||
| In the Temporal Worker Controller project, we cut two different kinds of Releases: | ||
|
|
||
| * **Application Release**: contains the Temporal Worker Controller container image. | ||
| * **Chart Release**: contains the Helm Charts that install the Temporal Worker | ||
| Controller and the Custom Resource Definitions (CRDs) used by the controller. | ||
|
|
||
| These different kinds of Releases are on different cadences and use different | ||
| version numbering. | ||
|
|
||
| ## Application Releases | ||
|
|
||
| Application Releases refer to the Temporal Worker Controller code and the | ||
| `temporalio/temporal-worker-controller` container image artifacts. | ||
|
|
||
| Release Tags for official Application Releases will always use Semantic Version | ||
| strings, e.g. `v1.42.1`. | ||
|
|
||
| We bump the minor version number of the Application Release version when new | ||
| features are added **to the controller code itself**. | ||
|
|
||
| Likewise, We bump the patch version number of the Application Release version | ||
| when bug fixes are added to the controller code itself. | ||
|
|
||
| > **IMPORTANT**: Changes to the Application Release version string's minor and | ||
| > patch versions **do not imply a change to either the Helm Chart Release | ||
| > version or the APIVersion of the CRDs supported by the controller**. | ||
|
|
||
| ## Chart Releases | ||
|
|
||
| Chart Releases refer to the two Helm Charts that install the Temporal Worker | ||
| Controller and manage the Custom Resource Definitions (CRDs) used by the | ||
| controller. | ||
|
|
||
| Release Tags for official Chart Releases are prefixed with the string `helm-` | ||
| and the Semantic Version string for the Chart Release, e.g. `helm-v0.24.0`. | ||
|
|
||
| **The major version of the Semantic Version string for the Chart Release refers | ||
| to the APIVersion of the CRDs.** | ||
|
|
||
| While the APIVersion of the CRDs is on the `v1alpha` series, the major version | ||
| of the Semantic Version string for the Chart Release will remain on `v0`. | ||
|
|
||
| When the APIVersion of the CRDs moves to the `v1` series, the major version of | ||
| the Semantic Version string for the Chart Release will be bumped to `v1`. | ||
|
|
||
| The minor version of the Semantic Version string for the Chart Release is | ||
| bumped when we change the structure of the Helm Chart itself -- by adding, | ||
| removing or modifying `values.yaml` options or adding, removing or modifying | ||
| Kubernetes resources in the `templates/` directory. | ||
|
|
||
| The patch version of the Semantic Version string for the Chart Release is | ||
| bumped when we release a new Application Release and update the `Chart.yaml`'s | ||
| `appVersion` field to point to a new Application Release. | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if we release a bug fix to the controller code itself, will we also cut a patch of the corresponding Helm Release so that users can install the bug fix via Helm?
This section made me concerned that maybe we would patch the image and not package that bug fix into a helm chart.
To take a step back, my understanding is that because many users install this code via Helm, whenever we release new controller code, we will always release it in some Helm Chart Version. And also if we change the chart but not the controller code, we might release a new Helm Chart Version. Are there cases where we would release new code but not put it in any Helm Chart release?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
overall looks good though! just want to make sure I understand this and we are communicating clearly