Closed
Conversation
Amp-Thread-ID: https://ampcode.com/threads/T-019d4d9e-7bc8-729d-a829-df0f7bde35a2 Co-authored-by: Amp <amp@ampcode.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
tx-tomcat
pushed a commit
to Magnus-Foundation/magnus
that referenced
this pull request
Apr 18, 2026
…g in swap order fills (#890) from https://tempoxyz.slack.com/archives/C09KCGR4LQ4/p1763009606739239?thread_ts=1762895220.576359&cid=C09KCGR4LQ4 ``` if remainingOut is 1: if price < PRICE_SCALE - baseNeeded and fillAmount is 1 and (fillAmount * price) / PRICE_SCALE is 0 if price > PRICE_SCALE - baseNeeded and fillAmount is 0 and (fillAmount * price) / PRICE_SCALE is also 0 only way it works is if price == PRICE_SCALE, it seems yikes Doing the conversion twice is bad, we are basically doing: filledAmount = ((remainingOut * PRICE_SCALE) / price) * price / PRICE_SCALE; if currentOrder.remaining > base we should be able to just zero remainingOut without the div, should fix the problem then PR with fix in solidity: tempoxyz/docs#221 ``` --------- Co-authored-by: 0xKitsune <77890308+0xKitsune@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds the T3 network upgrade page following the same structure as T2. Covers TIP-1011 (enhanced access keys), TIP-1020 (signature verification precompile), TIP-1022 (virtual deposit forwarding addresses), and TIP-1038 (security hardening).