fix: og:image title/description not rendering#371
Merged
juandolealt merged 1 commit intomainfrom May 2, 2026
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
URLSearchParams was encoding %title → %25title before Vocs could replace the placeholder with the actual page title. Build the query string manually so the %title and %description placeholders survive intact for Vocs substitution. Co-authored-by: Amp <amp@ampcode.com> Amp-Thread-ID: https://ampcode.com/threads/T-019de67d-9b8f-73f8-90e3-e9a6c7c5c0f4
decofe
force-pushed
the
agent-1777692085-26589-10973
branch
from
d8187e2 to
733eb83
Compare
decofe
force-pushed
the
agent-1777692085-26589-10973
branch
from
733eb83 to
1d7f69a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem: OG images show literal
%titleinstead of the actual page title (e.g. "Send a Payment"). This affects all non-landing pages.Root cause:
URLSearchParamsin theogImageUrlconfig function URL-encodes%title→%25title, so Vocs's.replace('%title', ...)substitution can't find the placeholder.Fix: Build the query string manually, keeping
%titleand%descriptionas bare placeholders for Vocs to substitute.