Conversation
Bundle Size Report
Chunk changes (>1KB)
Compared against main branch (baseline from 4/27/2026, 4:02:54 PM) |
Cloudflare Deployments
|
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 5e783038de
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| }), | ||
| ]) | ||
| const result = await consumeRateLimit({ | ||
| limiter: env.EXPLORER_EXPORT_RATE_LIMIT, |
There was a problem hiding this comment.
This call now passes env.EXPLORER_EXPORT_RATE_LIMIT into a RateLimit parameter, but the committed generated bindings still type that env var as a durable object namespace, so pnpm --filter explorer check:types fails with TS2741 (limit is missing). That blocks the required type-check/precommit path until worker types are regenerated (or the binding type is otherwise updated) in the same change.
Useful? React with 👍 / 👎.
| "new_sqlite_classes": ["ExplorerExportRateLimit"] | ||
| "name": "EXPLORER_EXPORT_RATE_LIMIT", | ||
| "namespace_id": "421701", | ||
| "simple": { "limit": 20, "period": 60 } |
There was a problem hiding this comment.
Setting simple: { "limit": 20, "period": 60 } weakens the previous throttle from 20 exports per 10 minutes to 20 per minute (up to 200 in the same 10-minute span). For CSV export endpoints this is a substantial policy change that can increase expensive query load and abuse potential unless explicitly intended.
Useful? React with 👍 / 👎.
1 participant
No description provided.