docs(fee-amm): fix rebalancing swap rate direction#2094
Closed
docs(fee-amm): fix rebalancing swap rate direction#2094
Conversation
Add specification for getFeeToken() view function in FeeManager precompile that allows smart contracts to read the fee token being used for the current transaction during execution. This feature was requested by LayerZero/Stargate for their integration with Tempo's TIP-20 fee system. Refs: #2085
The rebalancing swap rate was incorrectly described as 'validator token per user token'. Since rebalancing swaps go from validatorToken to userToken, the rate should be expressed as 'user token per validator token' to be consistent with how fee swaps describe their rate (output per input). Changed 0.9985 to 1.0015 (= 10000/9985) to reflect the correct ratio.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Member
|
Moved to tempoxyz/docs#11 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The rebalancing swap rate was incorrectly described as validator token per user token. Since rebalancing swaps go from
validatorToken→userToken, the rate should be expressed as user token per validator token to be consistent with how fee swaps describe their rate (output per input).Changes
0.9985to1.0015(= 10000/9985)Fixes issue reported in Slack by Tanishk: https://tempoxyz.slack.com/archives/C0A87C21805/p1768504458988599