-
Notifications
You must be signed in to change notification settings - Fork 279
feat(precompiles): TIP-1026 add logoURI and createToken overload T5+ #3745
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
fgimenez
wants to merge
12
commits into
main
Choose a base branch
from
fgimenez/tip-1026-impl
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
13bd14d
feat(precompiles): TIP-1026 add logoURI and createToken overload T5+
fgimenez 72507af
test(tip-1026): cover logo_uri in TIP20 Solidity layout-equivalence test
fgimenez a361981
test(tip-1026): assert deploy-time LogoURIUpdated has updater = msg.s…
fgimenez 7c5b5df
test(tip-1026): accept truncated allowlisted-scheme URIs in fuzz URI …
fgimenez 8e17d69
test(tip-1026): pin pre-T5 deploy / post-T5 logoURI read returns empty
fgimenez c627a36
docs(tip-1026): note scheme allowlist is consensus-critical + clarify…
fgimenez 30010aa
docs(tip-1026): align logoURI setter docs with # Errors style and pin…
fgimenez 3bd1a3e
test(tip-1026): unit-test validate_logo_uri directly and collapse red…
fgimenez a2048fd
Apply suggestions from code review
fgimenez 8abe2dc
refactor(tip-1026): group logoURI helpers as associated items on TIP2…
fgimenez 553fb5c
refactor(tip-1026): reuse unused _domain_separator slot for logo_uri …
fgimenez 1750707
Merge branch 'main' into fgimenez/tip-1026-impl
fgimenez File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.