feat: enforce tranfer from msg.sender in system_transfer_from#3836
Open
klkvr wants to merge 2 commits intoklkvr/tip-1035from
Open
feat: enforce tranfer from msg.sender in system_transfer_from#3836klkvr wants to merge 2 commits intoklkvr/tip-1035from
klkvr wants to merge 2 commits intoklkvr/tip-1035from
Conversation
klkvr
requested review from
0xKitsune,
0xrusowsky,
fgimenez,
legion2002,
mattsse and
rakita
as code owners
Contributor
📊 Tempo Precompiles CoverageprecompilesCoverage: 5648/7749 lines (72.89%) File details
contractsCoverage: 1/226 lines (0.44%) File details
Total: 5649/7975 lines (70.83%) |
0xalpharush
reviewed
May 6, 2026
| return Err(TIP20Error::unauthorized().into()); | ||
| } | ||
|
|
||
| if self.storage.msg_sender() != Some(from) { |
Contributor
There was a problem hiding this comment.
Should this be an assert?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.