Fix for issue #325 - Multidate picker#326
Open
tonix-tuft wants to merge 2 commits intotempusdominus:masterfrom
Open
Fix for issue #325 - Multidate picker#326tonix-tuft wants to merge 2 commits intotempusdominus:masterfrom
tonix-tuft wants to merge 2 commits intotempusdominus:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Demonstration of the issue
https://jsfiddle.net/fjcqm0hu/1/
The same issue happens on the documentation website (https://tempusdominus.github.io/bootstrap-4/Usage/#multidate).
If all the dates of a picker in multidate mode are removed by clicking on each selected date until there are no more selected, an error
Uncaught TypeError: Cannot read property 'isSame' of undefinedoccurs.What the change does
Fixes the issue #325, which does not log the following error on the console anymore when all the dates of a picker in multidate mode are unset: