add ModelzClient.create_completion classmethod #24
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Has llmspec been published? I'll declare it as a dependency if yes. |
kemingy
reviewed
May 16, 2023
| ModelzResponse(resp) | ||
| console.print(f"created the build job for repo [bold cyan]{repo}[/bold cyan]") | ||
|
|
||
| @classmethod |
Member
There was a problem hiding this comment.
Any reason to create the class method?
Comment on lines
+155
to
+165
| try: | ||
| from llmspec import LLMSpec | ||
|
|
||
| # Instantiate LLMSpec and transform the prompt | ||
| llmspec = LLMSpec(prompt) | ||
| transformed_prompt = llmspec.to_model(model) | ||
| except ImportError as err: | ||
| raise ImportError( | ||
| "llmspec is required for LLM models" | ||
| "\nPlease install it with the command `pip install llmspec" | ||
| ) from err |
Comment on lines
+167
to
+175
| # Prepare request params | ||
| request_params = {"prompt": transformed_prompt} | ||
| if params: | ||
| request_params.update(params) | ||
|
|
||
| # Get the inference result | ||
| response = client.inference(request_params, deployment, serde) | ||
|
|
||
| return response |
Member
There was a problem hiding this comment.
If so, why not use client.inference directly? Why do we need a new function?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add ModelzClient.create_completion classmethod that provides a similar interface to openai's: